"Online users"

hmm, it's messed up in IE6 and 7, firefox it looks great

put some padding in and stuck it down bottom for now.

I reckon it looks better at the bottom anyway.... but yeah the css doesn't work in in IE.

The commas don't work because IE is shit. But I don't understand why the text doesn't wrap. If we have more than about 15 registered users online it'll cause problems (or lower resolutions).

Going to remove space around comma and replace with padding quickly.

added to privatemsg* and libcommunity pages

how is it coded, because just now there were two rows of online users but the first row was Alf, then jef, then costello was o the second line followed by another 8 or so names. Is this just a glitch or has it been coded to push up to make a secod line rather than continue down (by adding a line on top rather than on the bottom)
I'm using firefox .

edit: ok it's stopped doing it now.

it's not very happy at the moment - we're trying to get it into a proper comma seperated list but not perfect at all yet.

Problem is it shouldnt be a list. Should re-do it imo.

yeah I thought that css would work, but it doesn't, sorry

not your fault! Felix if you see this - we could do with a hand figuring out how to format it as not a list i think, its in the users.module.

bump

I can help you with this, but how would you like it to look? I'm not sure what you mean with "format it not as a list".

The default output of the users is ul li. We made it look like a comma seperated list via css (li.after) etc. but it's got internet explorer compatibility issues. So an easier thing might be a foreach $user something something - output as simply a list seperated by commas rather than unordered list.

Don't worry about it too much, I'm gradually picking things up and might be able to attack it over the next few weeks, but on the other hand feel free if you fancy it!

It's easy to change, and all the concerned functions are themeable. Right now it's using a generic Drupal function for making lists of stuff . If you make the changes there, this might change how other listed stuff on the site looks, but you can also make the changes for the user list only.

Yeah it's changing it just for user lists and replacing the function we want to do. I was hoping there was a "display as comma seperated" function somewhere but I don't think so.

Here's a new user_list function for you. I haven't tested it though, so it will probably need some debugging.

function theme_user_list($users, $title = NULL) {
  $output = '<div class="item-list">';
  if (isset($title)) {
    $output .= '<h3>'. $title .'</h3>';
  }
  if (!empty($users)) {
    foreach ($users as $user) {
      $data = theme('username', $user);
      $output .= $data . ', ';
    }
  }
  $output .= '</div>';
  return $output;
}

thankyou muchly!