DONATE NOW TO HELP UPGRADE LIBCOM.ORG

xhtml validation

6 posts / 0 new
Last post
Mike Harman
Offline
Joined: 7-02-06
Mar 26 2007 18:42
xhtml validation

Started this about forums, but we should probably have one thread for everything.

Forums:

the inconsistency with the right sidebar might be down to unclosed tags somewhere. Ran a validation check on the editing sigs thread:

http://validator.w3.org/check?uri=http%3A%2F%2Flibcom.org%2Fforums%2Ffee...

missing an end div for this:

div class="forum-comment">

that might be it. There's other little things as well.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 26 2007 18:52

yeah makes sense....

Here it is from template.php though, closed as far as i can see:

function libcomz_comment_view($comment, $links = array(), $visible = 1) {
static $first_new = TRUE;

$output = '';
$comment->new = node_mark($comment->nid, $comment->timestamp);
if ($first_new && $comment->new != MARK_READ) {
// Assign the anchor only for the first new comment. This avoids duplicate
// id attributes on a page.
$first_new = FALSE;
$output .= "\n";
}

click edit to see - code isnt working now

Mike Harman
Offline
Joined: 7-02-06
Mar 26 2007 18:54

I took a look in node-forum.tpl.php - we've got 6 div and 5 /div - so must be one of them. Could be an old thing from flatforum ages back we've not spotted.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 26 2007 19:03
Mike Harman wrote:
I took a look in node-forum.tpl.php - we've got 6 div and 5 /div - so must be one of them. Could be an old thing from flatforum ages back we've not spotted.

Err? Was that a copy you from today? Becuase i just counted and there were 7 of each! Anyway the div thing doesnt seem to be an issue now...

Mike Harman
Offline
Joined: 7-02-06
Mar 26 2007 19:21

you're right, must be going mad sad

felix frost just posted a correction on the other thread though.

Felix Frost's picture
Felix Frost
Offline
Joined: 30-12-05
Mar 26 2007 19:33

catch is right. I didn't close my div's properly.

If you look closely on the code above, you will find that the <div> tags only close when the if condition is true. Which is why we had to move the opening <div> inside the if statement.