Bbcode/ quicktags

21 posts / 0 new
Last post
Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Feb 28 2007 14:41
Bbcode/ quicktags

Am fixing these now.

Steven.'s picture
Steven.
Offline
Joined: 27-06-06
Feb 28 2007 15:09

the URL one is now shit again, it was finally good as well... it puts in the http automatically which always fucks up everyone's links...

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Feb 28 2007 15:10

Yeah i cant do it. leaving it as is until I can figure it out

Steven.'s picture
Steven.
Offline
Joined: 27-06-06
Feb 28 2007 15:12

ok cool. sorry didn't mean to be grumpy. quote one is back, that's good!

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Feb 28 2007 15:15

np

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Feb 28 2007 15:38

They are all there now. Gunna stick with those images, because right now the changes are hardcoded in. need to move to template php and replace bbcode.module with a clean one.

Steven.'s picture
Steven.
Offline
Joined: 27-06-06
Feb 28 2007 16:02

cool.

Mike Harman
Offline
Joined: 7-02-06
Feb 28 2007 18:07

Cool. I dunno how quicktags/bbcode works but let me know if you need a hand.

It'd be good to stop broken quotes messing up the layout as well, that'd be a lovely thing.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 1 2007 00:36
Quote:
It'd be good to stop broken quotes messing up the layout as well, that'd be a lovely thing.

Its meant do do that anyway :/
http://libcom.org/notes/content-guidelines/bbcode (scroll to the bottom to see examples). I have a feeling its to do with flat forum and the float alignments on how the posts are constructed

Im just trying to get the hook for it to work in template.php but for some reason it wont - perhaps because quicktags is not a module - its a input filter.

Mike Harman
Offline
Joined: 7-02-06
Mar 1 2007 09:03

Pretty sure that's it- because the buttons do javscript thingies it probably won't work at theme level.

Did you look at this?

http://webschuur.com/node/628

Looks like the most upgradeable way would be to make our own module for the other buttons. We could take one of the drupal module examples, stick that code in for each button, that'd be it.

Flatforum floats, that's annoying if so, sounds like it could be it.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 1 2007 18:22

Flatforum is absolute cack. I reckon with some time we could work on it and make it better. I have no idea why drupal neglects the core forum module so much.

Yeah i looked at that and was trying to work from it.

Is that really all there is to making the module? Cos i could just copy form the bbcode module then. Might have a go now.

Also have u seen in input forms on last.fm how the buttons are constructed? Its nice.

Mike Harman
Offline
Joined: 7-02-06
Mar 1 2007 18:27

bit more to module - needs .info file (simple) as well. And probably something top and bottom to say it's a module,maybe, never done it...

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 1 2007 18:51

Ok that was piss easy.

Ref nicequicktags.module

It works but i have no idea why it overrides the hooks in bbcode module.

Mike Harman
Offline
Joined: 7-02-06
Mar 1 2007 18:58

Very cool!

what do you mean by overrides - as in redefines every button, not just extra ones?

Reckon we can use modules/template.php to do a lot of things (like getting rid of signatures) so we don't need to hack core and get into upgrade messiness.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 1 2007 19:02
Quote:
what do you mean by overrides - as in redefines every button, not just extra ones?

What i have done is copied the function_hook thing out of the bbcode module (which redfined the quicktags which existed in quicktags.module). Then i have modified it by adding new ones and altering existing ones. But that function_hook thing is still bbcode.module but its now also (in a slightly different form) in my.module. I just dont understand how my.module takes precedence!

Not sure what u mean by modules/template.php but im sure i'll find out when we get there wink

Mike Harman
Offline
Joined: 7-02-06
Mar 1 2007 19:07

Basically any changes we need to make - we can do it by overriding functions in modules and template.php instead of having to hack modules - so instead of loads of hacks, we have a few little modules which do all the changes and we can just drop-in after any upgrades.

Dunno why your module takes precedence either!

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 1 2007 19:11

Ok i get it. Still tidying up these buttons.

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 1 2007 19:32

Got stuck on close button.

Steven.'s picture
Steven.
Offline
Joined: 27-06-06
Mar 1 2007 20:13

could you get rid of the "url name here" bit of url button? it's pretty annoying...

Jacques Roux's picture
Jacques Roux
Offline
Joined: 17-07-06
Mar 1 2007 20:17

Its not there wink

Re-did the buttons, cos i'm in a graphic-y mood and i <3 lastfm

Mike Harman
Offline
Joined: 7-02-06
Mar 1 2007 20:18

oooh, so much nicer!